fix(react): correctly init options when value (or defaultValue) provided #1849
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josokinas
force-pushed
the
fix/init-options-value
branch
from
26ae14d to
b86bd75
Compare
zoeradkani
approved these changes
Jul 25, 2022
josokinas
force-pushed
the
fix/init-options-value
branch
from
b86bd75 to
f974c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a case when options not initialized correctly with
valueordefaultValueset.Approach
Initiate with 1st option only in case of no current value set, otherwise look up for it.
Testing
Tested locally via Storybook.
Risks
N/A