fix: selectors applied conditionally #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 993badc has been successfully built and deployed to https://onfido-castor-preview-pr-209.surge.sh 🕐 Build time: 123.543s
🤖 By surge-preview |
rabelloo
force-pushed
the
fix/input-textarea-focus-border
branch
from
07872db to
a1ff6ea
Compare
josokinas
approved these changes
Jan 20, 2021
rabelloo
force-pushed
the
fix/wrapped-self-selectors
branch
from
a97ab73 to
84e1b52
Compare
Sass' `&` will output the selector twice, which is why the linter disallows it, and our conditional selectors should account for that.
rabelloo
force-pushed
the
fix/wrapped-self-selectors
branch
from
84e1b52 to
993badc
Compare
|
P.S. Should this be |
|
Yea the PR title didn't update but I included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sass'
&will output the selector twice,which is why the linter disallows it,
and our conditional selectors should account for that.
Approach
Apply with
@ifinstead of functionifwhich allows for better content control.Create mixin for shareability.
Testing
Check output CSS.
Risks
Reorders stylelint rule,
@includebefore$variable, which honestly is a better separation and allows local variables to be used in mixins.