-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add field-label component #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 6795a72 has been successfully built and deployed to https://onfido-castor-preview-pr-267.surge.sh 🕐 Build time: 146.496s 🤖 By surge-preview |
63cd080
to
2ac9658
Compare
josokinas
commented
Feb 4, 2021
rabelloo
reviewed
Feb 8, 2021
9d2054b
to
1c2e04d
Compare
1c2e04d
to
27b47b4
Compare
rabelloo
approved these changes
Feb 9, 2021
150262a
to
22cb6af
Compare
rabelloo
reviewed
Feb 9, 2021
35e14af
to
1d7ba45
Compare
rabelloo
reviewed
Feb 9, 2021
closes #4
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-authored-by: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
1d7ba45
to
6795a72
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add FieldLabel component.
Approach
Implements FieldLabel component.
This closes issue #4.
Testing
On Storybook preview.
Risks
N/A