feat(react): deprecate "children" for adding input/textarea label #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview d1185d7 has been successfully built and deployed to https://onfido-castor-preview-pr-622.surge.sh 🕐 Build time: 156.002s
🤖 By surge-preview |
…"children" When using Input or Textarea component, use "label" prop to provide a label instead of previously "children" one used.
josokinas
force-pushed
the
feat/input-textarea-label
branch
from
5eaee3f to
56dc00b
Compare
rabelloo
reviewed
Apr 28, 2021
rabelloo
reviewed
Apr 28, 2021
rabelloo
reviewed
Apr 28, 2021
packages/react/src/internal/field-label-wrapper/field-label-wrapper.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
josokinas
force-pushed
the
feat/input-textarea-label
branch
from
879a435 to
c2c58cb
Compare
josokinas
changed the title
rabelloo
reviewed
Apr 29, 2021
rabelloo
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Using "children" prop to display a label on React's Input and Textarea is not very accurate, because "children" on Textarea has another meaning, also e.g. for Select component this also will not work - options will need to be provided via children instead.
Approach
Deprecate usage of "children" prop on Input and Textarea components, suggest component composition instead.
Testing
N/A
Risks
N/A