Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jpeg file type for documents #102

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

filnko
Copy link
Contributor

@filnko filnko commented Jul 12, 2024

Hi,

as I can't open issues here, I need to open a PR :-)
(this PR shouldn't be merged like this of course)

When requesting documents that the WebSDK uploaded, they have a file_type of "jpeg". The OpenAPI spec however only lists "jpg" as allowed value.
Somehow this should be adapted as your API is not working according to the specification.

Example response from the api:

GET https://api.eu.onfido.com/v3.6/documents/2e503b6a-99c6-4829-802b-9e43903b7c22
{
    "applicant_id": "ce61a2a3-4190-43d2-b634-e7bdabad760b",
    "id": "2e503b6a-99c6-4829-802b-9e43903b7c22",
    "file_name": "document_back.jpeg",
    "file_type": "jpeg",
    "file_size": 2610325,
    [...]
}

Thanks, Christoph

@dvacca-onfido
Copy link
Contributor

@filnko Thanks for your contribution, even though minimal your change looks good to me.

We're going to merge that as it's for now, in future we'll probably remove enum format from file_type property also to align with other endpoints. That can't be done right now since it would cause a breaking change in the libraries.

@dvacca-onfido dvacca-onfido marked this pull request as ready for review July 15, 2024 13:32
@dvacca-onfido dvacca-onfido merged commit 40b86a1 into onfido:master Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants