Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for the download evidence folder endpoint #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HoneyryderChuck
Copy link
Contributor

No description provided.

/workflow_runs/{workflow_run_id}/evidence_folder:
get:
description: |
Retrieves the signed evidence folder for the designated Workflow Run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Retrieves the signed evidence folder for the designated Workflow Run
Retrieves the evidence folder for the designated Workflow Run

get:
description: |
Retrieves the signed evidence folder for the designated Workflow Run
operationId: download_signed_evidence_folder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
operationId: download_signed_evidence_folder
operationId: download_workflow_run_evidence_folder

description: Found
headers:
Location:
description: Link to the signed evidence folder.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Link to the signed evidence folder.
description: Link to the evidence folder.

schema:
$ref: '#/components/schemas/Error'
description: Unexpected error
summary: Retrieve Workflow Run Evidence Summary File

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: Retrieve Workflow Run Evidence Summary File
summary: Retrieve Workflow Run Evidence Folder

Copy link
Contributor

@dvacca-onfido dvacca-onfido Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelfteixeira please move your comments inside the original files (as files inside the generated folder are automatically built)

@HoneyryderChuck please remove generated files from PR and run ./shell/run-prettier.sh script to make the linter is happy about the changes, as in README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants