Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checker/interpreter NFT tests to use actual NFT contracts #2503

Closed
Tracked by #2642 ...
dsainati1 opened this issue May 22, 2023 · 4 comments
Closed
Tracked by #2642 ...

Update checker/interpreter NFT tests to use actual NFT contracts #2503

dsainati1 opened this issue May 22, 2023 · 4 comments

Comments

@dsainati1
Copy link
Contributor

Issue to be solved

Changes to the checker and interpreter during the development of Stable Cadence have caused the unit tests using the NFT (and other core) contracts to fail, and as such the test contracts were updated locally. These updates are going to be out of sync with the actual core contracts, and once the core contracts are updated for Stable Cadence these tests should be updated to reflect the actual core contracts.

Suggested Solution

No response

@turbolent
Copy link
Member

turbolent commented Aug 15, 2023

Related: #2719

@j1010001
Copy link
Member

Alternative to #3608

@SupunS
Copy link
Member

SupunS commented Oct 10, 2024

Probably the source codes are updated in #3471. Might just need to double check and "enable" the disabled tests.

@turbolent
Copy link
Member

Let's remove the tests once the Source Compatibility Suite is testing the contracts again, i.e. when #3608 is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants