Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup outdated FT/NFT related contract codes and tests #3630

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 18, 2024

Closes #2719, #2503

Description

There are still codes mimicking the actual FT/NFT contracts. e.g:

const modifiedFungibleTokenContractInterface = `

These are used by the

  • Benchmarks:

    func BenchmarkRuntimeFungibleTokenTransfer(b *testing.B) {

    Where the code is mostly used as some token transfer logic, only to benchmark the cadence runtime implementation, and doesn't necessarily has to reflect the exact FT/NFT contracts.

  • Recovery tests:

    func TestRuntimeBrokenFungibleTokenRecovery(t *testing.T) {

    Here also, it is only needed to check the recovery logic works, and doesn't has to reflect the actual FT/NFT contracts

So kept these ones as is. All these contracts are already updated to C1.0 (#3471).


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 18, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0b1fc2b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS marked this pull request as ready for review October 18, 2024 21:58
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👍

@SupunS SupunS merged commit d96a90d into master Oct 18, 2024
11 of 12 checks passed
@SupunS SupunS deleted the supun/cleanup branch October 18, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable disabled contract tests
2 participants