Cleanup outdated FT/NFT related contract codes and tests #3630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2719, #2503
Description
There are still codes mimicking the actual FT/NFT contracts. e.g:
cadence/tests/ft_test.go
Line 38 in 0b1fc2b
These are used by the
Benchmarks:
cadence/tests/ft_test.go
Line 583 in 0b1fc2b
Where the code is mostly used as some token transfer logic, only to benchmark the cadence runtime implementation, and doesn't necessarily has to reflect the exact FT/NFT contracts.
Recovery tests:
cadence/tests/ft_test.go
Line 928 in 0b1fc2b
Here also, it is only needed to check the recovery logic works, and doesn't has to reflect the actual FT/NFT contracts
So kept these ones as is. All these contracts are already updated to C1.0 (#3471).
master
branchFiles changed
in the Github PR explorer