Delegate storage address to Atree #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, storage address is derived from StorageID(). In the future, some Atree values can be inlined so they don't have StorageID and address needs be derived differently. This commit delegates storage address to its internal Atree values, by calling Address().
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 5f84e78 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 336 336
Lines 77869 77873 +4
=======================================
+ Hits 61207 61211 +4
Misses 14379 14379
Partials 2283 2283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
turbolent
approved these changes
Jul 5, 2023
|
Is there maybe a way we can also prevent future uses of |
@turbolent Good point! 👍 It would be great to unexport fields in |
|
@fxamacker Sounds good! BTW, it's OK if there are breaking changes in the API, we can adjust Cadence accordingly, only breaking changes to the storage format (i.e. need for storage migration) are a concern |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates onflow/atree#292
Description
Currently, storage address is derived from
StorageID().In the future, some Atree values can be inlined so they don't have
StorageIDand address needs be derived differently.This PR delegates storage address to its internal Atree values, by calling
Address().masterbranchFiles changedin the Github PR explorer