Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: Add decode functionality for cadence.StorageReference and cadence.Link #264

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

psiemens
Copy link
Contributor

Description

This PR adds decoding functionality that mirrors the JSON-CDC encoding functionality recently added for cadence.StorageReference and cadence.Link types.

We previously discussed this not being a strict requirement, but it is useful for users who use JSON-CDC as a storage format and therefore need to convert to/from cadence.Value and JSON (e.g. the Playground).

@psiemens psiemens requested a review from turbolent as a code owner July 24, 2020 04:39
@psiemens psiemens self-assigned this Jul 24, 2020
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@psiemens psiemens merged commit ed48031 into master Jul 24, 2020
@psiemens psiemens deleted the decode-links-storage-refs branch July 24, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants