Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atree register inlining for v1.0 #3048

Merged
merged 55 commits into from
Apr 8, 2024

Merge pull request #3170 from onflow/fxamacker/use-atree-readonly-ite…

fccfa81
Select commit
Loading
Failed to load commit list.
Merged

Atree register inlining for v1.0 #3048

Merge pull request #3170 from onflow/fxamacker/use-atree-readonly-ite…
fccfa81
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 4, 2024 in 0s

80.62% (+0.02%) compared to 40b4d69

View this Pull Request on Codecov

80.62% (+0.02%) compared to 40b4d69

Details

Codecov Report

Attention: Patch coverage is 84.70982% with 137 lines in your changes are missing coverage. Please review.

Project coverage is 80.62%. Comparing base (40b4d69) to head (fccfa81).

Files Patch % Lines
runtime/interpreter/value.go 89.30% 48 Missing and 3 partials ⚠️
runtime/interpreter/decode.go 65.90% 25 Missing and 5 partials ⚠️
runtime/interpreter/encode.go 66.66% 10 Missing and 2 partials ⚠️
migrations/legacy_intersection_type.go 70.00% 5 Missing and 1 partial ⚠️
runtime/convertValues.go 82.35% 4 Missing and 2 partials ⚠️
runtime/interpreter/statictype.go 86.66% 4 Missing ⚠️
runtime/interpreter/storagemapkey.go 80.00% 4 Missing ⚠️
runtime/interpreter/value_link.go 33.33% 4 Missing ⚠️
runtime/interpreter/value_function.go 0.00% 3 Missing ⚠️
migrations/legacy_primitivestatic_type.go 75.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@                           Coverage Diff                            @@
##           feature/atree-register-inlining-v1.0    #3048      +/-   ##
========================================================================
+ Coverage                                 80.60%   80.62%   +0.02%     
========================================================================
  Files                                       379      379              
  Lines                                     91151    91604     +453     
========================================================================
+ Hits                                      73468    73854     +386     
- Misses                                    15049    15110      +61     
- Partials                                   2634     2640       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov