Fix migration of built-in types #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit a0dd6cf Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3205 +/- ##
=======================================
Coverage 80.74% 80.75%
=======================================
Files 380 380
Lines 93307 93359 +52
=======================================
+ Hits 75339 75389 +50
- Misses 15260 15262 +2
Partials 2708 2708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
force-pushed
the
bastian/3192-authaccount-type-loading
branch
from
6fd3ddb
to
356d854
Compare
turbolent
changed the title
turbolent
commented
Apr 2, 2024
dsainati1
approved these changes
Apr 2, 2024
turbolent
commented
Apr 2, 2024
turbolent
commented
Apr 2, 2024
This was referenced Apr 2, 2024
SupunS
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3192
Description
Built-in types (location == nil) may be represented as
CompositeStaticTypeinstead of the simplifiedPrimitiveStaticType. This is because we're not properly normalizing the types e.g. during import, in the type construction functions, etc.Start cleaning this up and handling this properly by extending the static type migration to convert
CompositeStaticTypetoPrimitiveStaticType, if the composite static type refers to a built-in type that should be represented by a primitive static type.In follow up PRs we should clean up the incorrect representation / construction (see examples above).
masterbranchFiles changedin the Github PR explorer