Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back transaction execute tests #3345

Merged
merged 9 commits into from
May 14, 2024
Merged

Add back transaction execute tests #3345

merged 9 commits into from
May 14, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 14, 2024

Port of https://github.com/dapperlabs/cadence-internal/pull/225 by @dsainati1

Description

This adds back a number of tests for destructor type checking and interpreting that were removed when destructors were removed, except rewritten to use transaction execute blocks. The majority of the removed tests relied on certain properties of destructors that don't apply to execute blocks, in particular the ability to re-enter and invoke destructors from within other functions. This doesn't apply to execute blocks, which can only be entered once from the top level, and as such those tests could not be ported. However, tests that didn't rely on that behavior and only made use of the relaxed checker rules for nested resource moves were ported.

This uncovered a runtime crash with recursive transfers, which luckily was fixed by @SupunS's work in #3342, and so this PR is based on top of that one. It also depends on #3331.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SupunS SupunS merged commit fb35240 into supun/port-222 May 14, 2024
@SupunS SupunS deleted the supun/port-225 branch May 14, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants