Add back transaction execute
tests
#3345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/dapperlabs/cadence-internal/pull/225 by @dsainati1
Description
This adds back a number of tests for destructor type checking and interpreting that were removed when destructors were removed, except rewritten to use transaction execute blocks. The majority of the removed tests relied on certain properties of destructors that don't apply to execute blocks, in particular the ability to re-enter and invoke destructors from within other functions. This doesn't apply to execute blocks, which can only be entered once from the top level, and as such those tests could not be ported. However, tests that didn't rely on that behavior and only made use of the relaxed checker rules for nested resource moves were ported.
This uncovered a runtime crash with recursive transfers, which luckily was fixed by @SupunS's work in #3342, and so this PR is based on top of that one. It also depends on #3331.
master
branchFiles changed
in the Github PR explorer