Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cadence Parser NPM Package #3551

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix Cadence Parser NPM Package #3551

merged 2 commits into from
Aug 27, 2024

Conversation

bluesign
Copy link
Contributor

@bluesign bluesign commented Aug 27, 2024

Closes #3550

Description

I fixed test and there was an issue with go.js ( I think go changed the runtime in some version )

( PS: Not sure if test fails caused not distributing to NPM )


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (4a1f236) to head (bcd5ff6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3551      +/-   ##
==========================================
- Coverage   80.40%   80.40%   -0.01%     
==========================================
  Files         393      393              
  Lines       97432    97439       +7     
==========================================
+ Hits        78339    78343       +4     
- Misses      16350    16352       +2     
- Partials     2743     2744       +1     
Flag Coverage Δ
unittests 80.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turbolent turbolent self-assigned this Aug 27, 2024
@turbolent turbolent merged commit f78982b into onflow:master Aug 27, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When will @onflow/cadence-parser release v1.0?
2 participants