Fix storage explorer #3627
Merged
Fix storage explorer #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 0bb1b69 Collapsed results for better readability
|
SupunS
approved these changes
Oct 18, 2024
| @@ -4,7 +4,7 @@ go 1.22 | |||
|
|
|||
| require ( | |||
| github.com/gorilla/mux v1.8.1 | |||
| github.com/onflow/atree v0.8.0-rc.6 | |||
| github.com/onflow/atree v0.8.0 | |||
| github.com/onflow/cadence v1.0.0-preview.52 | |||
There was a problem hiding this comment.
Maybe also update to the v1.0.1 tag?
There was a problem hiding this comment.
This was just a go mod tidy run, the dependencies were already outdated before. We can update to the latest Cadence version in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix dependencies / breakage due to restructuring. The storage explorer depends on flow-go, which has not been updated to the restructured Cadence codebase.
Fix this by temporarily removing the replace statement to use the "current" Cadence version, and change the import statements back to the old repository structure.
Once flow-go got updated, we can update the storage explorer to use the new imports.
masterbranchFiles changedin the Github PR explorer