Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release docs with a section for versioning strategy #3629

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 18, 2024


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Documentation Improvements or additions to documentation label Oct 18, 2024
@SupunS SupunS self-assigned this Oct 18, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0b1fc2b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS marked this pull request as ready for review October 18, 2024 19:37
@SupunS SupunS requested a review from jsproz October 18, 2024 19:37
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@turbolent turbolent merged commit 0170c96 into master Oct 21, 2024
10 of 12 checks passed
@bluesign
Copy link
Contributor

I was just gonna ask something about this: what is the definition of "language-breaking change" ?

@SupunS
Copy link
Member Author

SupunS commented Oct 21, 2024

@bluesign

what is the definition of "language-breaking change" ?

A change where an existing Cadence code could be breaking, is considered a language-breaking change. i.e: any backwards incompatible change to the cadence language spec (we don't have the spec documented yet, but in WIP)

@SupunS SupunS deleted the supun/versioning branch October 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants