Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable and update the Source Compatiblity Suite GitHub action #3632

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 18, 2024

Work towards #3608

Description

Now that the Source Compatibility Suite was updated thanks to @RZhang05, we can re-enable the GitHub Action for it.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 18, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit d96a90d
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit 553c7ee into master Oct 21, 2024
9 of 12 checks passed
@turbolent turbolent deleted the bastian/reenable-compat-suite-action branch October 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants