[v1.0] Port security fixes #3653

turbolent · 2024-10-29T22:17:50Z

Description

Port security fix PRs

Comparison: https://github.com/dapperlabs/cadence-internal/compare/f87b338f39aa839085ce59bd779ceb7a658e78b2^...v1.0

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

github-actions · 2024-10-29T22:24:28Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v1.0 commit ea09836
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
DecodeBatchEventsCCF-4	124ms ± 0%	123ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	356ms ± 0%	357ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.76µs ± 0%	2.73µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	2.06µs ± 0%	2.04µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.70µs ± 0%	2.79µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.05µs ± 0%	3.08µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	2.08µs ± 0%	2.15µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.42µs ± 0%	2.41µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.48µs ± 0%	2.49µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.39µs ± 0%	2.40µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	2.05µs ± 0%	2.04µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.51µs ± 0%	2.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	9.27µs ± 0%	9.00µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.17µs ± 0%	5.18µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	8.01µs ± 0%	7.98µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	11.0µs ± 0%	11.0µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	5.30µs ± 0%	5.29µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	6.78µs ± 0%	6.92µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	7.06µs ± 0%	7.12µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	6.39µs ± 0%	6.79µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	5.21µs ± 0%	5.25µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	7.07µs ± 0%	7.15µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	84.5ms ± 0%	81.8ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	99.0ms ± 0%	98.4ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.88µs ± 0%	1.82µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.48µs ± 0%	1.48µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.77µs ± 0%	1.75µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.08µs ± 0%	2.05µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.52µs ± 0%	1.51µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.63µs ± 0%	1.60µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.68µs ± 0%	1.66µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.67µs ± 0%	1.64µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.48µs ± 0%	1.45µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.71µs ± 0%	1.66µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.34µs ± 0%	2.34µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.37µs ± 0%	1.39µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.12µs ± 0%	2.09µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.15µs ± 0%	2.84µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.38µs ± 0%	1.39µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.77µs ± 0%	1.77µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	2.02µs ± 0%	2.02µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.63µs ± 0%	1.61µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.36µs ± 0%	1.37µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	2.02µs ± 0%	2.01µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	261ns ± 0%	270ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	77.1ns ± 0%	76.9ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	1.88ms ± 0%	2.04ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	852ns ± 0%	846ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	353ns ± 0%	360ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	5.98ms ± 1%	5.98ms ± 2%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	8.93ms ± 1%	13.33ms ±22%	~	(p=0.333 n=2+2)
ParseDeploy/decode_hex-4	1.04ms ± 2%	2.46ms ±60%	~	(p=1.000 n=2+2)
ParseFungibleToken/With_memory_metering-4	148µs ± 2%	219µs ± 6%	~	(p=0.333 n=2+2)
ParseFungibleToken/Without_memory_metering-4	116µs ± 3%	192µs ± 5%	~	(p=0.333 n=2+2)
ParseInfix-4	5.23µs ± 0%	5.19µs ± 1%	~	(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-4	2.17ns ± 0%	2.17ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	83.3ns ± 0%	79.5ns ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	579µs ± 0%	581µs ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.58µs ± 0%	3.61µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	236ns ± 0%	218ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	91.7ns ± 0%	92.1ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	298ns ± 0%	297ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	66.9ns ± 0%	61.3ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
DecodeBatchEventsCCF-4	66.5MB ± 0%	66.5MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	242MB ± 0%	242MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.40kB ± 0%	1.40kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.49kB ± 0%	1.49kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.26kB ± 0%	1.26kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.32kB ± 0%	1.32kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.30kB ± 0%	1.30kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.33kB ± 0%	1.33kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	5.95kB ± 0%	5.95kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.38kB ± 0%	5.38kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.30kB ± 0%	7.30kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.59kB ± 0%	3.59kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.49kB ± 0%	4.49kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.41kB ± 0%	4.41kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	63.9MB ± 0%	63.9MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	40.7MB ± 0%	40.7MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.47kB ± 0%	1.47kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.44kB ± 0%	1.44kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.46kB ± 0%	1.46kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.23kB ± 0%	1.23kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	896B ± 0%	896B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	536B ± 0%	536B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	920B ± 0%	920B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.11kB ± 0%	1.11kB ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	584B ± 0%	584B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	784B ± 0%	784B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	808B ± 0%	808B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	672B ± 0%	672B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	544B ± 0%	544B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	800B ± 0%	800B ± 0%	~	(all equal)
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	960B ± 0%	960B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.66MB ± 1%	2.66MB ± 1%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	4.20MB ± 0%	4.23MB ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/With_memory_metering-4	29.8kB ± 0%	29.8kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4	29.8kB ± 0%	29.8kB ± 0%	~	(p=0.667 n=2+2)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	166kB ± 0%	165kB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.36kB ± 0%	3.36kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	4.60M ± 0%	4.60M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	124 ± 0%	124 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	100 ± 0%	100 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	157 ± 0%	157 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	68.0 ± 0%	68.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	85.0 ± 0%	85.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	84.0 ± 0%	84.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	1.00M ± 0%	1.00M ± 0%	~	(all equal)
EncodeBatchEventsJSON-4	902k ± 0%	902k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/byte_array-4	89.4k ± 0%	89.4k ± 0%	~	(p=0.667 n=2+2)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	3.22k ± 0%	3.22k ± 0%	~	(all equal)
RuntimeScriptNoop-4	50.0 ± 0%	50.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

turbolent added 14 commits October 29, 2024 14:57

prevent predeclared members to get confused using user-defined types

487e31a

forbid attachment conformances

5f28dda

forbid change of attachment base type

3f384d5

put attachment base type change validation behind a feature flag

1e6ee46

put attachment conformances behind feature flag

7849504

put sibling type check for members behind a feature flag

605fc95

invert feature flag

74b0135

enable v1.0.1 features based on current version

03826a5

rename new version function

8ae61ac

update to latest version of golang.org/x/crypto

88dbd9d

remove feature flags

02cd846

add error return value to MinimumRequiredVersion interface function

e996077

make EmptyRuntimeInterface.MinimumRequiredVersion a no-op

ee97355

return a valid semver

bc01ae1

turbolent added the Bugfix label Oct 29, 2024

turbolent requested a review from jsproz October 29, 2024 22:17

turbolent self-assigned this Oct 29, 2024

turbolent requested a review from SupunS as a code owner October 29, 2024 22:17

SupunS approved these changes Oct 29, 2024

View reviewed changes

turbolent merged commit c9db8c7 into v1.0 Oct 30, 2024
10 of 12 checks passed

turbolent deleted the bastian/port-security-fixes branch October 30, 2024 01:05

turbolent mentioned this pull request Oct 30, 2024

Port security fixes #3654

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.0] Port security fixes #3653

[v1.0] Port security fixes #3653

turbolent commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

[v1.0] Port security fixes #3653

[v1.0] Port security fixes #3653

Conversation

turbolent commented Oct 29, 2024

Description

github-actions bot commented Oct 29, 2024

Cadence Benchstat comparison