Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expressions in string template #3662

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Support expressions in string template #3662

merged 5 commits into from
Nov 14, 2024

Conversation

RZhang05
Copy link
Contributor

Working towards #3579

Description

This PR extends the work in #3585, as planned to support expressions.

Reopening of #3625

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 31, 2024
@SupunS SupunS added the Feature label Oct 31, 2024
@RZhang05 RZhang05 marked this pull request as ready for review November 12, 2024 18:58
turbolent
turbolent approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

SupunS
SupunS reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

parser/expression_test.go Show resolved Hide resolved
parser/expression_test.go Outdated Show resolved Hide resolved
interpreter/misc_test.go Outdated Show resolved Hide resolved
SupunS
SupunS approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

parser/expression_test.go Outdated Show resolved Hide resolved
@SupunS SupunS merged commit d155b01 into onflow:master Nov 14, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@turbolent turbolent turbolent approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@SupunS SupunS

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RZhang05 @turbolent @SupunS