Support new import syntax through config.load

[justinbarry]

Addresses: #1514

[changeset-bot]

🦋 Changeset detected

Latest commit: 58656c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@onflow/config	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[chasefleming]

Lots of good stuff here, but a few missing pieces still I think.

• I don't think we should use placeholders (e.g. 0xHelloWorld) for storing v2 contract aliases in config. We want to get away from them so something more hidden like lib.contract.0xHelloWorld or something I think would be better. Less change people will use them then. And then flow v1 syntax won't occasionally work with v2 causing confusion.
• I don't actually see the handling of the new import syntax mentioned in the CLI issue. That would be handled in resolve-cadence.js. Think that needs to get added.
• I think the v2 json is slightly incorrect, but could be wrong. cc'd @sideninja on that.

Also, can you link a ticket and update the title to the type, package, description format please?

[sideninja]

Looks good, left couple of comments, I think it's good idea to add another test proving the resolution of address

[chasefleming]

I just found a bug in the load. It wasn't created in this PR, but can we fix it in it? The bug is that it still warns about private keys if you use a CLI env var like $FLOW_EMULATOR_PRIVATE_KEY instead of the from path. Can we also just make it not flag if you're using the $ method for env vars from CLI

[fotescodev]

@justinbarry sir! We just got another good piece of feedback on flow dev / flow setup commands, and it's dependent on the FCL's support of the new JSON Schema: onflow/flow-cli#826

How can we move forward with this PR?

[justinbarry]

I just found a bug in the load. It wasn't created in this PR, but can we fix it in it? The bug is that it still warns about private keys if you use a CLI env var like $FLOW_EMULATOR_PRIVATE_KEY instead of the from path. Can we also just make it not flag if you're using the $ method for env vars from CLI

Let's make that another issue so I can get this out for testing. My hope was we would get this into master ready to release, but I don't think it is going to work out that way.

[justinbarry]

Given Flow.json V2 is yet to be out in the wild, I ripped out all the references to it, and we can add them back later at a future date. The only outstanding question is what happens when a contract in flow.json has both an alias and a deployment.... which one wine? @sideninja Let's talk about this in the morning. Otherwise, this should be good to go.

[sideninja]

@justinbarry
It shouldn't have it, but even it does always prioritize the alias. Ofc it can have deployments and alias in case of a specific network. So you can imagine it has an alias for testnet but it's also in deployments because on emulator the deployments is used since there's no alias for emulator. So for the network you are using if the alias exists use that, otherwise you can use the deployment.