PKG -- [util-address] Generate types from JSDoc #1547
Conversation
🦋 Changeset detectedLatest commit: 36459af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1 @@ | |||
| {"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.js"],"names":[],"mappings":"AAAA;;;;GAIG;AACF,oCAHU,MAAM,GACJ,MAAM,CAKlB;AAED;;;;GAIG;AACH,oCAHW,MAAM,GACJ,MAAM,CAKlB;AAED;;;;GAIG;AACH,iCAHW,MAAM,GACJ,MAAM,CAIlB"} | |||
There was a problem hiding this comment.
Should this be checked in?
There was a problem hiding this comment.
I was wondering the same thing. Can remove if that's what everyone thinks.
| * @param {string} address - Flow address | ||
| * @returns {string} - Flow address without 0x prefix | ||
| */ | ||
| export function sansPrefix(address: string): string; |
There was a problem hiding this comment.
Given this is a build product akin to the dist folder can we ignore these files in .gitignore?
There was a problem hiding this comment.
It would make the build step easier, but don't most libraries have their type files committed?
There was a problem hiding this comment.
Not if they are generated. Usually, they go into the dist folder.
There was a problem hiding this comment.
If you do find an example of what we are doing here out in the wild, I would be curious to see it.
Addresses: #1537, #1536