Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [sdk] Add JSDoc to SDK methods #1573

Merged
merged 12 commits into from
Mar 6, 2023
Merged

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Mar 1, 2023

Addresses: #1537, #1493

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

🦋 Changeset detected

Latest commit: 758c10c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@justinbarry justinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nit picks. Otherwise looks good!

packages/sdk/src/build/build-get-block-header.js Outdated Show resolved Hide resolved
packages/sdk/src/build/build-get-block.js Outdated Show resolved Hide resolved
packages/sdk/src/build/build-get-collection.js Outdated Show resolved Hide resolved
@chasefleming chasefleming marked this pull request as ready for review March 6, 2023 18:46
@chasefleming chasefleming requested a review from a team as a code owner March 6, 2023 18:46
@chasefleming chasefleming merged commit 74c75d5 into master Mar 6, 2023
@chasefleming chasefleming deleted the chasefleming/sdk-type-gen branch March 6, 2023 18:55
@github-actions github-actions bot mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants