Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [config] Fix types #1604

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

chasefleming
Copy link
Member

Addresses: #1603

Also let's dev import types from fcl instead of package

@chasefleming chasefleming requested a review from a team as a code owner March 29, 2023 19:56
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

🦋 Changeset detected

Latest commit: aaa6645

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JeffreyDoyle
Copy link
Member

Let's close this, and enforce importing types as a separate package.

@chasefleming chasefleming changed the title PKG -- [config] Fix types and export PKG -- [config] Fix types Apr 5, 2023
@chasefleming chasefleming merged commit a4a1c7b into master Apr 5, 2023
@chasefleming chasefleming deleted the chasefleming/config-types-fix branch April 5, 2023 18:29
@github-actions github-actions bot mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants