Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [fcl] Retry on network error is page is not visible during backchannel polling #1623

Merged
merged 3 commits into from
Apr 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-pugs-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@onflow/fcl": patch
---

PKG -- [fcl] Retry on network error is page is not visible during backchannel polling
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,22 @@ export async function poll(service, canContinue = () => true) {
invariant(service, "Missing Polling Service", {service})
if (!canContinue()) throw new Error("Externally Halted")

const resp = await fetchService(service, {
method: serviceMethod(service),
}).then(normalizePollingResponse)
let resp
try {
resp = await fetchService(service, {
method: serviceMethod(service),
}).then(normalizePollingResponse)
} catch (error) {
if (
typeof document !== "undefined" &&
document.visibilityState === "hidden"
) {
await new Promise(r => setTimeout(r, 500))
return poll(service, canContinue)
} else {
throw error
}
}

switch (resp.status) {
case "APPROVED":
Expand Down