Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [fcl] Skip network requests when polling on service if document is not visible #1640

Merged
merged 2 commits into from
May 16, 2023
Merged

PKG -- [fcl] Skip network requests when polling on service if document is not visible #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725dd43
PKG -- [fcl] Skip network requests when polling on service if documen…
JeffreyDoyle May 8, 2023
6efd58a
PKG -- [fcl] Skip network requests when polling on service if documen…
JeffreyDoyle May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-parents-argue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@onflow/fcl": patch
---

PKG -- [fcl] Skip network requests when polling on service if document is not visible
12 changes: 6 additions & 6 deletions packages/fcl/src/current-user/exec-service/strategies/utils/poll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@ export async function poll(service, canContinue = () => true) {

let resp
try {
resp = await fetchService(service, {
method: serviceMethod(service),
}).then(normalizePollingResponse)
} catch (error) {
if (
typeof document !== "undefined" &&
document.visibilityState === "hidden"
) {
await new Promise(r => setTimeout(r, 500))
return poll(service, canContinue)
} else {
throw error
}

resp = await fetchService(service, {
method: serviceMethod(service),
}).then(normalizePollingResponse)
} catch (error) {
throw error
}

switch (resp.status) {
Expand Down