Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKG -- [fcl] Fixed android polling #1703

Merged
merged 4 commits into from
Jun 27, 2023
Merged

PKG -- [fcl] Fixed android polling #1703

merged 4 commits into from
Jun 27, 2023

Conversation

nialexsan
Copy link
Contributor

No description provided.

@nialexsan nialexsan requested a review from jribbink June 23, 2023 02:40
@nialexsan nialexsan requested a review from a team as a code owner June 23, 2023 02:40
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39d313a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JeffreyDoyle
JeffreyDoyle requested changes Jun 23, 2023
View reviewed changes
packages/fcl/src/current-user/exec-service/strategies/http-post.js
} catch (error) {
console.error("Frame Close Error", error)
}
}
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mechanic is a bit confusing to me, could we perhaps rename the variables canCondinue shouldContinue to include more info on their purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments explaining the flow

@nialexsan nialexsan requested a review from JeffreyDoyle June 23, 2023 18:50
@jribbink jribbink linked an issue Jun 23, 2023 that may be closed by this pull request
[BUG] FCL React Native cannot dismiss auth session on Android #1697
Closed
@nialexsan nialexsan merged commit 8dcb70c into master Jun 27, 2023
@nialexsan nialexsan deleted the rn-android-fix-part-1 branch June 27, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

@JeffreyDoyle JeffreyDoyle JeffreyDoyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] FCL React Native cannot dismiss auth session on Android
3 participants
@nialexsan @JeffreyDoyle @jribbink