Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Feature: Multiple contracts per account - Milestone 2 #109

Closed
wants to merge 1 commit into from

Conversation

soetop
Copy link
Contributor

@soetop soetop commented Oct 30, 2021

Description

This PR is for Flipfest issue 21.

  • frontend: project default loading with multiple contracts per account
  • frontend: contracts can be added, edited, deployed and deleted
  • backend: support the above interactions

Check out the demo video

To-dos and known-issues

Submission Links & Documents

Backend: flow-playground-api has been forked and work is done on flip-21 branch

Run datastore emulator first

  gcloud beta emulators datastore start

Then run the server

  make run-datastore

Frontend: flow-playground has been forked and work is done on flip-21 branch

  npm install
  npm run start

flip-21 milestone 2
@MaxStalker
Copy link
Contributor

@soetop can you raise PRs for proposed changes, so it would be easier to review?

@kerrywei
Copy link

kerrywei commented Nov 5, 2021

@soetop can you raise PRs for proposed changes, so it would be easier to review?

bump @soetop could you open PRs so that we can start review? right now the changes reside in a branch, making it very hard to add comments.

@soetop
Copy link
Contributor Author

soetop commented Nov 6, 2021

hello @MaxStalker and @kerrywei,

you mean I merge to master then make PRs to respective repositories?

@kerrywei
Copy link

kerrywei commented Nov 6, 2021

hello @MaxStalker and @kerrywei,

you mean I merge to master then make PRs to respective repositories?

@soetop You can create a pull request via a forked repo by following https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

@soetop
Copy link
Contributor Author

soetop commented Nov 7, 2021

thanks @kerrywei
I made PRs to respective repositories.

fixed
I am still working to fix a few known issues. One issue is regarding Cadence code check on transactions as can be seen below. Deployed contracts are not found in declarations.

screenshot

However, transactions can be executed successfully as contracts actually exist.

I am looking into Cadence server code base to get clues. I would appreciate much if you could point me in the right direction.

@kerrywei
Copy link

Closing this PR given milestone 2 is not fully achieved -- the Max is working with @soetop in onflow/flow-playground#177 and onflow/flow-playground-api#14.
Meanwhile, thank you for participating in the FLIP FEST @soetop and great job of finishing milestone 1!

@kerrywei kerrywei closed this Nov 12, 2021
@soetop
Copy link
Contributor Author

soetop commented Nov 18, 2021

hello @kerrywei and @srinjoyc

I have made more commits incorporating reviews from PoC, Max and code owners.

Please reconsider to change this PR on Flipfest from closed to merged.
PRs in flow-playground and flow-playground-api will be merged later on.

For your reference, I have made documentation here:
https://laser-teal-a79.notion.site/Notes-for-changes-Flipfest-21-b2c49263e87a4551b57826070fe566a6

For quick reference, I have made a screen recording:
https://youtu.be/PEB1A5GRAbA

It has been a fulfilling experience to work on this FlipFest issue. Thank you for the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants