Add CLI Feature: Hot commands #406
Conversation
sakshamb2113
requested review from
janezpodhostnik,
Kay-Zee,
psiemens and
sideninja
as code owners
sakshamb2113
changed the title
internal/quick/deploy.go
Outdated
| var DeployCommand = &command.Command{ | ||
| Cmd: &cobra.Command{ | ||
| Use: "deploy", | ||
| Short: "Deploy contracts", |
There was a problem hiding this comment.
More clarity maybe: Deploy all project contracts
internal/quick/run.go
Outdated
| "HotCommand": "true", | ||
| }, | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| project.DeployCommand.Cmd.Run(cmd, args) |
There was a problem hiding this comment.
Wouldn't this two commands be swapped in order?
There was a problem hiding this comment.
Great effort so far, one thing that is problematic and needs changing is the fact that if you now use help with any of the commands you get a "hot commands" section, so for example, if I try to run flow accounts --help I will get first an empty "hot commands" section, but the way we want this to work is to only show that on the top "flow" command help.
|
I have made the changes and updated the code. Could you please have a look at it now ? |
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 55.33% 55.24% -0.09%
==========================================
Files 36 36
Lines 1874 1877 +3
==========================================
Hits 1037 1037
- Misses 707 710 +3
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR is for onflow/flip-fest#14
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer