-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch local dev wallet instance from emulator #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments but looking great, great work again 🚀
As far as unit testing goes, you can use |
@bluesign was the branch merged with state management just now? Because I see changes from that branch now. |
Oh I messed up probably was just trying to push to Janez about other issue, let me fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review all parts, as I haven't played around with the dev wallet much, but I went through how this interacts with the emulator code and it looks good :)
looking forward to see the usage documentation.
@bluesign try to resolve conflicts so this can be marked as done. Also please add a documentation explaining how to run this, you can add it to the readme. |
Last couple of small comments I have:
These are all quite minor things so even if ignored it's a valid submission. |
@sideninja thanks, I am updating now. any idea why CI giving error at check-tidy? |
did you run tidy again? This kind of CI problems are usually related to go.sum |
Description
Emulator launches a local dev wallet instance.
For Flip Fest: onflow/flip-fest#11
I am planning documentation update after this, but not sure about how to unit test this.
For contributor use:
master
branch