Skip to content

Commit

Permalink
fix races in network test middleware
Browse files Browse the repository at this point in the history
  • Loading branch information
SaveTheRbtz committed Apr 12, 2022
1 parent 4851614 commit 71b3fdc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions network/test/middleware_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,12 @@ func (m *MiddlewareTestSuite) SetupTest() {
var errChan <-chan error
m.mwCtx, errChan = irrecoverable.WithSignaler(ctx)

mwCtx := m.mwCtx
go func() {
select {
case err := <-errChan:
m.T().Error("middlewares encountered fatal error", err)
case <-m.mwCtx.Done():
case <-mwCtx.Done():
return
}
}()
Expand Down Expand Up @@ -425,7 +426,7 @@ func (m *MiddlewareTestSuite) TestLargeMessageSize_SendDirect() {
require.NoError(m.Suite.T(), err)

// check message reception on target
unittest.RequireCloseBefore(m.T(), ch, 15*time.Second, "source node failed to send large message to target")
unittest.RequireCloseBefore(m.T(), ch, 60*time.Second, "source node failed to send large message to target")

m.ov[targetIndex].AssertExpectations(m.T())
}
Expand Down

0 comments on commit 71b3fdc

Please sign in to comment.