Update checkpoint file format version from v4 to v5 #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version of checkpoint file to v5. Support reading v4 for compatibility. Add tests and test data to read v4.
fxamacker
requested review from
ramtinms,
m4ksio and
AlexHentschel
as code owners
ramtinms
approved these changes
Mar 22, 2022
m4ksio
approved these changes
Mar 23, 2022
| if err != nil { | ||
| log.Fatal().Err(err).Msg("invalid root checkpoint") | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I wonder if it would be a bit more future-proof if we have an upper version boundary here and error out if the version is higher than expected rather than assuming forward compatibility
fxamacker
merged commit c90c1db
into
fxamacker/optimize-encoded-payload-value-length-in-checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Updates #1944 (checkpoint file format v4)
Updates #2126 #2165 (checkpoint file format v5)