Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFT Testing] Gossipsub spam test Framework - IHAVE #3564

Merged
merged 162 commits into from
Jan 11, 2023

Conversation

gomisha
Copy link
Contributor

@gomisha gomisha commented Nov 14, 2022

This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages.

It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer.

ref: https://github.com/dapperlabs/flow-go/issues/6455

@gomisha gomisha self-assigned this Nov 14, 2022
@gomisha gomisha changed the base branch from master to yahya/6423-gossipsub-spamming-test November 14, 2022 21:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #3564 (1dd0ac7) into master (0d20f26) will decrease coverage by 9.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
- Coverage   55.35%   46.18%   -9.18%     
==========================================
  Files         768      114     -654     
  Lines       70194    11664   -58530     
==========================================
- Hits        38857     5387   -33470     
+ Misses      28153     5970   -22183     
+ Partials     3184      307    -2877     
Flag Coverage Δ
unittests 46.18% <ø> (-9.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fvm/environment/value_store.go 55.23% <0.00%> (-2.80%) ⬇️
fvm/transactionVerifier.go 82.32% <0.00%> (-2.13%) ⬇️
fvm/derived/derived_block_data.go 30.55% <0.00%> (-1.80%) ⬇️
fvm/context.go 53.47% <0.00%> (-1.47%) ⬇️
fvm/transactionSequenceNum.go 70.00% <0.00%> (-1.16%) ⬇️
fvm/transactionInvoker.go 80.51% <0.00%> (-0.19%) ⬇️
fvm/environment/facade_env.go 98.10% <0.00%> (ø)
fvm/environment/derived_data_invalidator.go 100.00% <0.00%> (ø)
network/p2p/test/fixtures.go
storage/merkle/node.go
... and 662 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gomisha
Copy link
Contributor Author

gomisha commented Jan 6, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 6, 2023
3564: [BFT Testing] Gossipsub spam test Framework - IHAVE r=gomisha a=gomisha

This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages.

It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE  control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer.

- initial implementation of a general purpose Spammer that will be used for future libp2p spam testing
- uses recent pubsub improvements like the RPC ingress message inspector (libp2p/go-libp2p-pubsub#509) to detect received messages on the victim node

ref: https://github.com/dapperlabs/flow-go/issues/6423

Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr>
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Build failed:

  • Integration Tests (make -C integration bft-tests)

…ptions()` match with `master`

still failing `TestGossipSubSignatureRequirement/TestGossipSubSignatureRequirement`
@gomisha
Copy link
Contributor Author

gomisha commented Jan 9, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 9, 2023
3564: [BFT Testing] Gossipsub spam test Framework - IHAVE r=gomisha a=gomisha

This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages.

It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE  control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer.

- initial implementation of a general purpose Spammer that will be used for future libp2p spam testing
- uses recent pubsub improvements like the RPC ingress message inspector (libp2p/go-libp2p-pubsub#509) to detect received messages on the victim node

ref: https://github.com/dapperlabs/flow-go/issues/6455

Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr>
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Required status check \"Unit Tests (Modules) (insecure, install-tools, test, 3, 1)\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@gomisha
Copy link
Contributor Author

gomisha commented Jan 11, 2023

bors merge

@bors bors bot merged commit 4a26d2c into master Jan 11, 2023
@bors bors bot deleted the misha/6423-gossipsub-spam-test branch January 11, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants