[Networking] Wires in GossipSub observability #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thep2p
commented
Dec 1, 2022
| logger zerolog.Logger | ||
| } | ||
|
|
||
| func NewObservableGossipSub(h host.Host, metrics module.GossipSubRouterMetrics, logger zerolog.Logger) *ObservableGossipSubRouter { |
There was a problem hiding this comment.
This component has been renamed and refactored to GossipSubControlMessageMetrics
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
+ Coverage 55.26% 55.30% +0.04%
==========================================
Files 756 756
Lines 69525 69488 -37
==========================================
+ Hits 38420 38428 +8
+ Misses 27955 27908 -47
- Partials 3150 3152 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 7d643c6 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
… into yahya/wire-observable-gossipsub
… into yahya/wire-observable-gossipsub
kc1116
approved these changes
Dec 1, 2022
peterargue
pushed a commit
that referenced
this pull request
Dec 1, 2022
* upgrades pubsub version * upgrades go sum * refactors observable gossipsub into metrics * wires up metrics * renames * switches the log level * go mod tidy
peterargue
pushed a commit
that referenced
this pull request
Dec 9, 2022
* upgrades pubsub version * upgrades go sum * refactors observable gossipsub into metrics * wires up metrics * renames * switches the log level * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades pubsub dependency to include our upstreamed changes for RPC inspector libp2p/go-libp2p-pubsub#509, and then implements a GossipSub observability component that logs and records the metrics around the incoming RPCs.
Sample log: