-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atree Inlining & Deduplication with Cadence v0.42 #5736
Atree Inlining & Deduplication with Cadence v0.42 #5736
Conversation
This commit updates bootstrap zero token commit hash in test because atree payloads changed with atree inlining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just one comment regarding the Cadence version. We can also do that in another PR if you want
…d-atree-inlining-to-feature-branch-atree-inlining-cadence-v0.42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question re: the TODO
…d-atree-inlining-to-feature-branch-atree-inlining-cadence-v0.42
CI seems to fail because of flaky tests, can probably ignore those |
I think the branch protection rules are broken again and so the CI check list requires checks that no longer exist/got renamed. Force merging, it's into a feature branch anyway |
df3c091
into
feature/atree-inlining-cadence-v0.42
This PR is to be used for building migration program needed by spork and running benchmarks.
This enables Atree Inlining & Deduplication with Cadence 0.42 in flow-go (e.g. atree migration program, etc.).
PR #5349 (in fxamacker branch) will be closed and we will start using this PR in a feature branch to build migration program.