-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow EVM] replace block.TransactionHashes with TransactionHashRoot #6222
[Flow EVM] replace block.TransactionHashes with TransactionHashRoot #6222
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6222 +/- ##
==========================================
- Coverage 41.48% 41.48% -0.01%
==========================================
Files 1978 1978
Lines 140843 140863 +20
==========================================
+ Hits 58433 58439 +6
- Misses 76335 76351 +16
+ Partials 6075 6073 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a Go-perspective! Can't say much regarding the business logic change
This PR depreciate the TransactionHashes field in the block and instead includes the root hash of all transaction hashes emitted during the transaction execution.
The block proposal keeps the list of tx hashes.