Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] replace block.TransactionHashes with TransactionHashRoot #6222

Merged
merged 15 commits into from
Jul 18, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Jul 16, 2024

This PR depreciate the TransactionHashes field in the block and instead includes the root hash of all transaction hashes emitted during the transaction execution.

The block proposal keeps the list of tx hashes.

Base automatically changed from ramtin/evm-delay-block-commit to master July 16, 2024 23:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 59.42029% with 28 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (9ea6fae) to head (76ea3b8).

Files Patch % Lines
fvm/evm/types/block.go 62.50% 20 Missing and 1 partial ⚠️
fvm/evm/types/utils.go 37.50% 5 Missing ⚠️
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6222      +/-   ##
==========================================
- Coverage   41.48%   41.48%   -0.01%     
==========================================
  Files        1978     1978              
  Lines      140843   140863      +20     
==========================================
+ Hits        58433    58439       +6     
- Misses      76335    76351      +16     
+ Partials     6075     6073       -2     
Flag Coverage Δ
unittests 41.48% <59.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms marked this pull request as ready for review July 17, 2024 20:03
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a Go-perspective! Can't say much regarding the business logic change

@ramtinms ramtinms added this pull request to the merge queue Jul 18, 2024
Merged via the queue into master with commit 3b62404 Jul 18, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-remove-tx-hashes-from-evm-blocks branch July 18, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants