FLIP-0636: NFT Metadata #636

briandilley · 2021-09-17T19:08:27Z

Closes: flip-fest #16

Description

Team Non Fungibles here submitting our proposal to the NFT Meta Data spec for the flip-fest.

Authors include:

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

vercel · 2021-09-17T19:08:31Z

@briandilley is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

flips/20210916-nft-metadata.md

turbolent · 2021-11-18T00:47:01Z

Nice work!

Co-authored-by: Bastian Müller <bastian@turbolent.com>

bjartek · 2021-12-02T11:42:51Z

I am not sure how to progress with merging changes here. But the latest work done here is here:

Resource that contains shared types

https://github.com/findonflow/find/blob/main/contracts/TypedMetadata.cdc

Proposed new NFT interface

https://github.com/findonflow/find/blob/main/contracts/standard/NonFungibleToken.cdc

Implementation for Versus

https://github.com/findonflow/find/blob/main/contracts/Art.cdc

…scussions with rhea and dete

vercel · 2021-12-07T02:12:37Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-docs/DWUywbvXto3fkVRwZzJp6i6k5WYx
✅ Preview: https://flow-docs-git-fork-the-nft-company-master-onflow.vercel.app

psiemens

This is mostly a semantic review. Great proposal overall!

flips/20210916-nft-metadata.md

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

flips/20210916-nft-metadata.md

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

flips/20210916-nft-metadata.md

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

psiemens

This looks good to go.

Thanks again @bjartek @briandilley and @bluesign!

dete

I don't see any remaining issues that should block this from proceeding. Great work, everyone!

flips/20210916-nft-metadata.md

dete

Oh shoot! I just noticed that the return type on resolveView doesn't have the ? to make it optional. I think this is preferred!

bjartek · 2021-12-14T18:46:10Z

Oh shoot! I just noticed that the return type on resolveView doesn't have the ? to make it optional. I think this is preferred!

I vaguely remember we talked about this and that this would be preferred to panicing the resolveView when you called it with a unknown view. I will fix it.

dete

👍

psiemens · 2021-12-15T19:23:01Z

I'm now merging this PR and will update the status to "accepted". Thanks again, everybody!

The contents of this FLIP will be soon added to the onflow/flow-nft repository alongside the base NFT interface.

briandilley added 2 commits September 16, 2021 15:39

Created first draft of NFT meta data spec proposal

aa1772a

Merge branch 'onflow:master' into master

5ab2f7e

briandilley mentioned this pull request Sep 17, 2021

New Standard: NFT metadata onflow/flip-fest#16

Closed

briandilley added 2 commits September 17, 2021 12:42

updated the examples a bit

d19a7ad

Update 20210916-nft-metadata.md

3562c48

briandilley mentioned this pull request Sep 17, 2021

New Standard: NFT metadata #16 - Milestone 1 onflow/flip-fest#35

Merged

turbolent reviewed Nov 18, 2021

View reviewed changes

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

psiemens changed the title ~~NFT Metadata propsoal for Flip Fest Issue #16~~ FLIP-0636: NFT Metadata Dec 1, 2021

bjartek and others added 4 commits December 2, 2021 12:18

Update flips/20210916-nft-metadata.md

65d3b4f

Co-authored-by: Bastian Müller <bastian@turbolent.com>

Update flips/20210916-nft-metadata.md

806b828

Co-authored-by: Bastian Müller <bastian@turbolent.com>

Update flips/20210916-nft-metadata.md

2286caf

Co-authored-by: Bastian Müller <bastian@turbolent.com>

Update flips/20210916-nft-metadata.md

7870d7f

Co-authored-by: Bastian Müller <bastian@turbolent.com>

updating the proposal based on the latest work done in FIND and in di…

6002d7d

…scussions with rhea and dete

vercel bot deployed to Preview December 7, 2021 02:12 View deployment

psiemens reviewed Dec 7, 2021

View reviewed changes

bjartek and others added 11 commits December 7, 2021 08:07

Update flips/20210916-nft-metadata.md

46d8ce2

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

b0c8983

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

60bef55

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

0ac0c1c

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

cdca3c2

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

c6b4e40

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

0722e45

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

c8354db

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

8fc11fd

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

7314652

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

Update flips/20210916-nft-metadata.md

e87953e

Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>

rudi-cilibrasi reviewed Dec 8, 2021

View reviewed changes

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

louisguitton approved these changes Dec 9, 2021

View reviewed changes

bjartek and others added 14 commits December 9, 2021 19:00

Update flips/20210916-nft-metadata.md

2179a79

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

e98cd93

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

d4fbb39

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

1e2bafc

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

fadab3c

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

571c987

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

5ec6f0d

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

239d1b4

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

e9f9772

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

3121078

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

a1558d4

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

0831605

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

Update flips/20210916-nft-metadata.md

0c0a46c

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

fixed inconsistent naming

291709e

louisguitton reviewed Dec 10, 2021

View reviewed changes

flips/20210916-nft-metadata.md Show resolved Hide resolved

bjartek and others added 2 commits December 10, 2021 17:51

Update flips/20210916-nft-metadata.md

1fecab8

Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>

remove royalty from the flip

e1ade1b

vercel bot deployed to Preview December 14, 2021 15:51 View deployment

psiemens approved these changes Dec 14, 2021

View reviewed changes

turbolent added the FLIP Flow Improvement Proposal label Dec 14, 2021

dete approved these changes Dec 14, 2021

View reviewed changes

flips/20210916-nft-metadata.md Outdated Show resolved Hide resolved

dete requested changes Dec 14, 2021

View reviewed changes

change to resolveView return AnyStruct?

16610ec

dete approved these changes Dec 14, 2021

View reviewed changes

vercel bot deployed to Preview December 15, 2021 01:08 View deployment

psiemens merged commit 65ffe87 into onflow:master Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FLIP-0636: NFT Metadata #636

FLIP-0636: NFT Metadata #636

briandilley commented Sep 17, 2021 •

edited by 10thfloor

Loading

vercel bot commented Sep 17, 2021

turbolent commented Nov 18, 2021

bjartek commented Dec 2, 2021

vercel bot commented Dec 7, 2021 •

edited

Loading

psiemens left a comment

psiemens left a comment

dete left a comment

dete left a comment

bjartek commented Dec 14, 2021

dete left a comment

psiemens commented Dec 15, 2021

FLIP-0636: NFT Metadata #636

FLIP-0636: NFT Metadata #636

Conversation

briandilley commented Sep 17, 2021 • edited by 10thfloor Loading

Description

vercel bot commented Sep 17, 2021

turbolent commented Nov 18, 2021

bjartek commented Dec 2, 2021

vercel bot commented Dec 7, 2021 • edited Loading

psiemens left a comment

Choose a reason for hiding this comment

psiemens left a comment

Choose a reason for hiding this comment

dete left a comment

Choose a reason for hiding this comment

dete left a comment

Choose a reason for hiding this comment

bjartek commented Dec 14, 2021

dete left a comment

Choose a reason for hiding this comment

psiemens commented Dec 15, 2021

briandilley commented Sep 17, 2021 •

edited by 10thfloor

Loading

vercel bot commented Dec 7, 2021 •

edited

Loading