Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade os-name to avoid crash on Windows #635

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

nichita-rusin
Copy link
Contributor

@nichita-rusin nichita-rusin commented Jun 10, 2024

Closes #634

Description

Downgrade version of os-name package to avoid fatal crash on Windows described in #634.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nichita-rusin
Copy link
Contributor Author

The fix of the original issue has been accepted into the windows-release package and is on the way to being accepted into os-name. We should wait a bit to roll the package version forward instead of backward!

@jribbink
Copy link
Contributor

The fix of the original issue has been accepted into the windows-release package and is on the way to being accepted into os-name. We should wait a bit to roll the package version forward instead of backward!

Oh ok awesome. I'll wait for that then 👍

@jribbink jribbink changed the title Downgrade os-name to avoid crash on Windows Upgrade os-name to avoid crash on Windows Jun 10, 2024
@jribbink jribbink merged commit ec8a6f6 into onflow:master Jun 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension does not activate on Windows 11
2 participants