Overriding index setting configuration bug #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .travis.yml # composer.json
|
Thanks for the PR @petrmalina |
|
Merged your commit in the 769cd3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920.
There were actually two problems.
One mentioned in the issue, merging values into arrays. That is fixed using array_replace_recursive instead of array_merge_recursive.
Second was caused by the array_filter and trying to set number_of_replicas to 0. Array filter converts the value to boolean FALSE and removes it from the array. I added a custom callback function to compare it using identical operator.