This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Scrollbar lags behind oni screen on resize #2114
Comments
akinsho
added a commit
that referenced
this issue
Aug 19, 2018
This PR fixes #2114 and a few issues with the buffer scroll bar The first issue relates to #2114 which was the fact the the buffer bar lagged behind if the window was resized. The specific change that fixes this is changing the position from `absolute` to `fixed` The other issue was that the error markers weren't rendering correctly i.e. only one error marker was shown in the buffer because the `uniqBy` function was filtering by Id but actually there was no id prop. Ive changed this to filter by line so the scroll bar just shows errors by line, meaning you now get multiple errors in the scroll bar based on position Also took the opportunity to change the components to styled components with dynamic attrs and added keys to the error components
psxpaul
pushed a commit
to psxpaul/oni
that referenced
this issue
Aug 20, 2018
This PR fixes onivim#2114 and a few issues with the buffer scroll bar The first issue relates to onivim#2114 which was the fact the the buffer bar lagged behind if the window was resized. The specific change that fixes this is changing the position from `absolute` to `fixed` The other issue was that the error markers weren't rendering correctly i.e. only one error marker was shown in the buffer because the `uniqBy` function was filtering by Id but actually there was no id prop. Ive changed this to filter by line so the scroll bar just shows errors by line, meaning you now get multiple errors in the scroll bar based on position Also took the opportunity to change the components to styled components with dynamic attrs and added keys to the error components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When the screen is resized if the scrollbar is set to active it lags behind resizing of the window briefly appearing in the center of the window. Not sure how easy this will be to solve but might be a css alignment issue, will post GIF shortly
NOTE: I'm using spectacle to snap windows to half width, but dragging also shows the problem as theres a discernible lag rather than the scroll bar being stuck to the edge it seems to trail behind briefly
The text was updated successfully, but these errors were encountered: