Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version lens extension fail with error #3238

Closed
pmizio opened this issue Mar 5, 2021 · 0 comments · Fixed by #3248
Closed

Version lens extension fail with error #3238

pmizio opened this issue Mar 5, 2021 · 0 comments · Fixed by #3248
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working platform-windows Platform: Windows

Comments

@pmizio
Copy link

pmizio commented Mar 5, 2021

Defect: Lenses for package.json not show up after selecting "Version Lens: Show dependency version"
In logs is something like this:

[INFO]  [22.021s] Oni2.Store.dispatch : dispatch: KeybindingInvoked {command = "list.select"; arguments = `Null}
[INFO]  [22.021s] Oni2.Store.dispatch : dispatch: ListSelect
[INFO]  [22.023s] Oni2.Store.dispatch : dispatch: (QuickmenuInputMessage Model.LostFocus)
[INFO]  [22.025s] Oni2.Store.dispatch : dispatch: (Extensions
   ExecuteCommand {command = "versionlens.onShowVersionLenses";
     arguments = <opaque>})
[ERROR] [22.030s] Oni2.Extension.ClientStore : {"$isError":true,"name":"Error","message":"Contributed command 'versionlens.onShowVersionLenses' does not exist.","stack":"Error: Contributed command 'versionlens.onShowVersionLenses' does not exist.\n\tat ExtHostCommands.$executeContributedCommand (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\api\\common\\extHostCommands.js:174:39)\n\tat RPCProtocol._doInvokeHandler (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:341:27)\n\tat RPCProtocol._invokeHandler (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:326:45)\n\tat RPCProtocol._receiveRequest (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:253:32)\n\tat RPCProtocol._receiveOneMessage (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:181:26)\n\tat C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\common\\rpcProtocol.js:65:52\n\tat Emitter.fire (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\common\\event.js:479:38)\n\tat BufferedEmitter.fire (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:375:35)\n\tat C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\workbench\\services\\extensions\\node\\extensionHostProcessSetup.js:146:41\n\tat Emitter.fire (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\common\\event.js:479:38)\n\tat BufferedEmitter.fire (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:375:35)\n\tat PersistentProtocol._receiveMessage (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:654:41)\n\tat C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:510:83\n\tat Emitter.fire (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\common\\event.js:479:38)\n\tat ProtocolReader.acceptChunk (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:189:37)\n\tat C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\common\\ipc.net.js:158:61\n\tat Socket.listener (C:\\Program Files\\Onivim2\\node\\node_modules\\@onivim\\vscode-exthost\\out\\vs\\base\\parts\\ipc\\node\\ipc.net.js:17:40)\n\tat Socket.emit (events.js:315:20)\n\tat addChunk (_stream_readable.js:295:12)\n\tat readableAddChunk (_stream_readable.js:271:9)\n\tat Socket.Readable.push (_stream_readable.js:212:10)\n\tat Pipe.onStreamRead (internal/stream_base_commons.js:186:23)"}
bryphe added a commit that referenced this issue Mar 8, 2021
@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working platform-windows Platform: Windows labels Mar 9, 2021
bryphe added a commit that referenced this issue Mar 10, 2021
#3248)

__Issue:__ The [VersionLens](https://open-vsx.org/extension/pflannery/vscode-versionlens) extension wasn't showing version info on Windows

__Defect:__ The codelens providers for version lens use document selectors with Windows-style paths, like `**\package.json` - but the glob utility we are using treats `\` as an escape character, so those globs were never matching correctly on Windows.

__Fix:__ Normalize the path separators for both the glob and the file paths we compare against, when checking to see if a provider matches the file path.

Fixes #3238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working platform-windows Platform: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants