Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File unsaved indication (close button being a circle) doesn't always reset on save file. #600

Closed
raguay opened this issue Aug 6, 2019 · 0 comments · Fixed by #672
Closed

File unsaved indication (close button being a circle) doesn't always reset on save file. #600

raguay opened this issue Aug 6, 2019 · 0 comments · Fixed by #672
Labels
bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor

Comments

@raguay
Copy link

raguay commented Aug 6, 2019

Actions

Open a file in onivim and make changes. Then :w or :wall to save it.

What happens

The close button on the file tab changes to a circle when you make edits. When you save it with :w or :wall, it still stays a circle.

Expected

The circle showing edits should change back to the x for closing the tab.

Strangeness

It doesn't always happen, but quit often. Mostly it's annoying.
@bryphe bryphe added bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor labels Aug 6, 2019
@bryphe bryphe mentioned this issue Aug 11, 2019
Open
This was referenced Aug 20, 2019
Merged
Merged
bryphe added a commit that referenced this issue Aug 20, 2019
@bryphe
Fix #600 - Unsaved / modified file indication is not reliable (#672)
26b28ba 
* Fix unsaved indicator

* Add integration test

* Formatting

* Update package/lockfiles
benox3 pushed a commit to benox3/oni2 that referenced this issue Aug 27, 2019
@bryphe @benox3
Fix onivim#600 - Unsaved / modified file indication is not reliable (o…
74bfe59 
…nivim#672)

* Fix unsaved indicator

* Add integration test

* Formatting

* Update package/lockfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #600 - Unsaved / modified file indication is not reliable onivim/oni2
2 participants
@raguay @bryphe