Add missing editor/folder specific title vars #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I also refactored nested structure of the |
bryphe
reviewed
Dec 25, 2019
|
|
||
| let dirty = | ||
| Option.map(Core.Buffer.isModified, buffer) | ||
| |> ( |
There was a problem hiding this comment.
I like the way you refactored out the withTag method and pipe into fun here - nice! 👍
bryphe
reviewed
Dec 25, 2019
| |> Option.map(Filename.dirname) | ||
| |> Option.bind(fp => | ||
| switch (rootPath) { | ||
| | Some((_, base)) => Some(Path.toRelative(~base, fp)) |
There was a problem hiding this comment.
Looks like the CI was failing because it expected ~base to be a named parameter. I made that quick change - 🤞 it passes now.
|
@bryphe Should i re-run checks manually? |
|
@amiralies - sorry about that, indeed the failure looks unrelated - kicking off another run |
|
/azp run |
|
Phew, build is green - thank you for the contribution, @amiralies ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #880