fix(exthost): Fix error when trying to read package metadata #1788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The python fails with an error when trying to read the extension metadata via the
vscode.extensions
API, here:Defect: The extension IDs we were sending to the extension host were improperly constructed. To be in sync with the extension host, they should be of the form
publisher.name
.Fix: Correctly construct the extension ID.
This gets us to the next round of blockers of the Python extension - it requires the
workspace.fs
API to implemented (it uses these operations to look for the.env
/ virtual environment setup).