Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exthost): Fix error when trying to read package metadata #1788

Merged
merged 7 commits into from
May 20, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented May 19, 2020

Issue: The python fails with an error when trying to read the extension metadata via the vscode.extensions API, here:

    const extensions = (require('vscode') as typeof import('vscode')).extensions;
    // tslint:disable-next-line:no-non-null-assertion
    const extension = extensions.getExtension(extensionId)!;
    // tslint:disable-next-line:no-unsafe-any
    const extensionVersion = extension.packageJSON.version;

Defect: The extension IDs we were sending to the extension host were improperly constructed. To be in sync with the extension host, they should be of the form publisher.name.

Fix: Correctly construct the extension ID.

This gets us to the next round of blockers of the Python extension - it requires the workspace.fs API to implemented (it uses these operations to look for the .env / virtual environment setup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant