-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(layout): keyboard navigation between sidebar, pane and editors #1924
Conversation
type panel = | ||
| Left | ||
| Center(int) | ||
| Bottom; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can easily be extended with Top
and Right
as well, but I didn't want to take that into account everywhere as long as we don't use it.
/azp run |
I noticed one bug - mentioned it in a code comment. Are there keybindings that work in the file explorer for moving the selection up/down? I thought we did have a concept of focus - and the arrow keys worked - but perhaps I'm mistaken. |
Yeah, up, down and enter are the only keybindings implemented so far. You need to have an existing focus though. (Edit: Oh, and it seems like the focus isn't set tot he current file if you open it without using the file explorer. I'll fix that in a separate PR) Now that all the infrastructure is in place, we ought to move the file explorer to a feature project, add commands for navigation and keybindings using those commands. Should be pretty straight-forward at this point I think. |
This adds keyboard navigation between editors, the sidebar and the bottom pane as an extension of the existing window movement keybindings. We lack good visual indication of where the keyboard focus actually is, but otherwise it works great!
Adding proper indication of focus will require some design work and is too big to in scope for this PR I think, but let me know if you think it should be added before merging.