Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout/#592): layout tabs - part 3 - single tab mode #2032

Merged
merged 3 commits into from
Jun 28, 2020

Conversation

glennsl
Copy link
Member

@glennsl glennsl commented Jun 27, 2020

This adds a "single tab mode" that hides the tab bar and restricts each group to a single tab. The effect of this is that :q will always close the split/group even if several buffers have been opened in it.

There is one caveat, however. If single tab mode is enabled when there are multiple tabs in a group, the extra tabs won't disappear immediately. Only when another buffer is opened will they be replaced. Any fix I can think of for this would be excessively complex for something that is designed to always be on or off, not toggled mid-session, so I doubt it's really worth it to fix it.

Addresses #592 - This should be the final piece of the puzzle for this, depending on how complete the support needs to be at this point.

@glennsl glennsl requested a review from bryphe June 27, 2020 14:44
@bryphe
Copy link
Member

bryphe commented Jun 27, 2020

This adds a "single tab mode" that hides the tab bar and restricts each group to a single tab. The effect of this is that :q will always close the split/group even if several buffers have been opened in it.

Awesome!

Any fix I can think of for this would be excessively complex for something that is designed to always be on or off, not toggled mid-session, so I doubt it's really worth it to fix it.

Assuming that's it's always on-and-off seems reasonable. We could potentially improve the UX or enforce this, like "this setting will be changed the next time you open Onivim" - but out of scope for this PR. Thanks for your work on this!

@glennsl glennsl merged commit 2470fbe into onivim:master Jun 28, 2020
@glennsl glennsl deleted the feat/layout/single-tab-mode branch June 28, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants