Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exthost): Send additional environment parameters to extension #2106

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jul 15, 2020

This adds a couple of extra variables that are required for extension host initialization:

  • globalStorageHome
  • userData

Any extension that uses vscode-extension-telemetry (any first party Microsoft extension, like vscode-python) - would fail without these, as the telemetry logger uses these to anonymize paths.

@bryphe bryphe merged commit 6bd145a into master Jul 16, 2020
@bryphe bryphe deleted the fix/exthost/set-approot branch July 16, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant