Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ux): Move search to sidebar #2415

Merged
merged 8 commits into from
Sep 9, 2020
Merged

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Sep 7, 2020

In starting to work on #528 - vim navigation for the file explorer (and other bits of UI, like search, SCM, etc) - there's some preliminary work that needs to happen. In particular, we need to refine our concept of 'Focus' - for example, we currently have 'Explorer' as a focus state, but as we break down #528 and look at features like #1785 (directory explorers) - we need to refine this. In particular, there could multiple 'explorers' in the view, and the focus might need some state along with - like the current selected item, information about the viewport (for zz, etc).

We'll need to 'fractalize' our focus state - we'll keep track of sort of the high-level place we have focus - for example, the Sidebar, and then from there, the Sidebar can route focus operations, like text-input and paste, to the appropriate piece, which can then delegate it further (for example, for search - one focus state will be input focus, and another will be navigating the search results). So just like we have a 'fractal' model for state - we'll need a 'fractal' model for focus to handle these cases.

In addition, a common request I get (mentioned in #1914, and comes up a lot in e-mail) is that the search behavior right now is confusing - all other buttons in the sidebar change the sidebar stop, but the search one opens up an extra pane. Since we can now resize the search pane, and it will simplify the focus-work described above (it would otherwise be a special case), figured it was a good to move it. The UX should still be improved - with the default sidebar size, it's difficult to interpret the results.

TODO:

  • Fix context menu behavior in new model - there are some cases where it stays open
  • Fix default focus for search / SCM / extensions

@bryphe bryphe added the WIP label Sep 7, 2020
bryphe added a commit that referenced this pull request Sep 8, 2020
This addresses a bullet point in #2415 - it removes the global state from the context menu, which made it highly coupled to any feature that needed to use a context menu.
@bryphe bryphe removed the WIP label Sep 8, 2020
@bryphe bryphe merged commit 881839e into master Sep 9, 2020
@bryphe bryphe deleted the feat/ux/search-sidebar-focus branch September 9, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant