Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension/#2640): Elm - Fix diagnostic display #2999

Merged
merged 2 commits into from
Jan 16, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Implement , wire up to BufferSaved
  • Loading branch information
bryphe committed Jan 15, 2021
commit 23270478d6847518c9f97e9aa9f199f8ec98ceec
7 changes: 7 additions & 0 deletions src/Service/Exthost/Service_Exthost.re
Original file line number Diff line number Diff line change
@@ -70,6 +70,13 @@ module Effects = {
dispatch(toMsg());
})
);

let modelSaved = (~uri, client, toMsg) => {
Isolinear.Effect.createWithDispatch(~name="exthost.modelSaved", dispatch => {
Exthost.Request.Documents.acceptModelSaved(~uri, client);
dispatch(toMsg());
});
};
};
module FileSystemEventService = {
let onFileEvent = (~events, extHostClient) =>
4 changes: 4 additions & 0 deletions src/Service/Exthost/Service_Exthost.rei
Original file line number Diff line number Diff line change
@@ -33,6 +33,10 @@ module Effects: {
unit => 'msg
) =>
Isolinear.Effect.t('msg);

let modelSaved:
(~uri: Oni_Core.Uri.t, Exthost.Client.t, unit => 'msg) =>
Isolinear.Effect.t('msg);
};

module FileSystemEventService: {
8 changes: 7 additions & 1 deletion src/Store/Features.re
Original file line number Diff line number Diff line change
@@ -1115,7 +1115,13 @@ let update =
},
extHostClient,
);
(state, eff);

let modelSavedEff =
Service_Exthost.Effects.Documents.modelSaved(
~uri=Buffer.getUri(buffer), extHostClient, () =>
Noop
);
(state, Isolinear.Effect.batch([eff, modelSavedEff]));

| BufferUpdated({update, newBuffer, oldBuffer, triggerKey}) =>
let fileType =