Packaging - Windows: Add ICO file #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrossR
reviewed
Jul 29, 2019
| @@ -36,6 +36,7 @@ const valuesToReplace = { | |||
| AppExecutableName: executableName, | |||
| AppSetupExecutableName: `${prodName}-${version}-${buildFolderPrefix}win`, | |||
| Version: version, | |||
| SetupIconFile: path.join(__dirname, "..", "..", "assets", "images", "oni2.ico"), | |||
There was a problem hiding this comment.
The "Icon"/"DefaultIcon" bits below will also need updating with this new path, since I just put a temp {app}\\oni2.ico one in.
There was a problem hiding this comment.
Thanks @CrossR for reviewing!
I think it should be OK - I added a line to copy the oni2.ico to the root application directory (the change above in scripts/release.js - so that {app}\\oni2.cio should be valid.
Seems like it works (although we'll need a better icon at some point!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
.icofile following up from @CrossR 's work in #486