Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Custom Titlebar #879

Merged
merged 22 commits into from
Oct 21, 2019
Merged

Feature: Custom Titlebar #879

merged 22 commits into from
Oct 21, 2019

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Oct 21, 2019 •
edited
Loading

Currently, our titlebar only says 'Oni2', which is not very helpful - especially when you have multiple instances open.

This PR adds a "window.title" option, like VSCode, with the intention of supporting a similar grammar. For example, our default configuration is:

  windowTitle: "${dirty}${activeEditorShort}${separator}${rootName}${separator}${appName}",

bryphe and others added 22 commits October 19, 2019 12:33
@bryphe bryphe merged commit d99801e into master Oct 21, 2019
@bryphe bryphe deleted the feature/custom-titlebar branch October 21, 2019 22:04
@bryphe bryphe mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bryphe